chart(feature): add dnsPolicy and dnsConfig support#3126
Merged
VietND96 merged 4 commits intoSeleniumHQ:trunkfrom Apr 27, 2026
Merged
chart(feature): add dnsPolicy and dnsConfig support#3126VietND96 merged 4 commits intoSeleniumHQ:trunkfrom
VietND96 merged 4 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
Review Summary by QodoAdd revisionHistoryLimit and dnsConfig support to Selenium Grid Helm chart
WalkthroughsDescription• Add revisionHistoryLimit support across all Selenium Grid components with global default of 10 and per-component overrides • Add dnsPolicy and dnsConfig support for pod DNS configuration at global and component levels • Update helper template to support DNS settings in pod specs including KEDA ScaledJob pods • Extend values.yaml with new configuration options for all components (hub, router, distributor, event bus, session map, session queue, and browser nodes) Diagramflowchart LR
A["Global Config<br/>revisionHistoryLimit<br/>dnsPolicy<br/>dnsConfig"] -->|"defaults"| B["Component Deployments<br/>hub, router, distributor<br/>eventBus, sessionMap<br/>sessionQueue"]
A -->|"defaults"| C["Browser Nodes<br/>chrome, firefox, edge"]
B -->|"per-component<br/>overrides"| D["Pod Specs<br/>with DNS & revision settings"]
C -->|"per-component<br/>overrides"| D
E["Helper Template<br/>_helpers.tpl"] -->|"renders"| D
File Changes1. charts/selenium-grid/templates/_helpers.tpl
|
Contributor
Code Review by Qodo
1. Zero revisionHistoryLimit ignored
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Expose pod dnsPolicy and dnsConfig across all Selenium Grid components
(hub, router, distributor, event bus, session map, session queue,
chrome/edge/firefox/relay nodes including KEDA ScaledJob pods, and the
videoManager file-browser). Configurable globally via
global.seleniumGrid.{dnsPolicy,dnsConfig} with per-component overrides,
mirroring the existing affinity / topologySpreadConstraints pattern.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
DrFaust92
force-pushed
the
add-dns-config
branch
from
63892a6 to
eb1bdae
Compare
DrFaust92
changed the title
Run helm-docs against values.yaml to surface the new dnsPolicy/dnsConfig entries added in eb1bdae across global, components.{router,distributor,eventBus,sessionMap,sessionQueue}, hub, chrome/firefox/edge/relay nodes, and videoManager. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Re-run helm-docs with --skip-version-footer to match the prior CONFIGURATION.md convention (no autogenerated trailer). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
helm-docs --skip-version-footer strips the footer plus the blank line that preceded it. Re-add the trailing newline to match the prior file shape. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
VietND96
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnsPolicyanddnsConfigacross all Selenium Grid components: hub, router, distributor, event bus, session map, session queue, chrome/edge/firefox/relay nodes (including KEDAScaledJobpods), and thevideoManagerfile-browser.global.seleniumGrid.{dnsPolicy,dnsConfig}with per-component overrides, mirroring the existingaffinity/topologySpreadConstraintspattern.Test plan
helm lintpasses (default values and with overrides).helm templatewith default values emits nodnsPolicy/dnsConfigkeys.helm templatewithglobal.seleniumGrid.dnsPolicy=ClusterFirstandglobal.seleniumGrid.dnsConfig.nameservers[0]=8.8.8.8propagates to all 11 components.components.router.dnsPolicy=Default,chromeNode.dnsConfig.options[0]={name: ndots, value: 3}) take precedence over globals.ScaledJobmode (autoscaling.scalingType=job) rendersdnsPolicy/dnsConfiginsidejobTargetRef.template.specfor chrome/edge/firefox/relay nodes.🤖 Generated with Claude Code